Jørn Wildt

Requests:

1 - When browsing as thumbnails, instead of the image comments being all of them _PTMP_THUMBNAILS_CLICKTOENLARGE it'd be nice if the comment could be the image description you entered when uploading the image (the first x cars)

2 - Don't know if it is even worth the hassle (and in fact this is just modifying thetemplate), buf it'd be nice if instead of seeing 5 pics on each row (thumbnail view again) it would ajust by itself to the screen width. At 1280x0124, 5 thumbnails at 80x80 hardly ocupy half screen :)

3 - When browsing albums, on top of all you always have:
Photoshare
All albums
It'd be great if you would view were you were, you could go up folders, and so on. Like on this forum, right now I'm at "Board index > feature requests > post new topic". It'd be nice to have something as:
Photoshare
All albums > mi holidays > amazonia 2001

Of course for this to be useful, nested folders should have to work completely :D

Keep up the good work Jorn, this module is very nice!

I think you will like the next version :)

1) Interesting and will perhaps be. You can always fix your own template.

2) Samething with the template. I don't know if the browser posts the screen size while making a request. If not you will have to resize the rows in JavaScript, or let the user choose a size.

3) Done for version 3.

Trying with 1)...
:D

Done... In case anyone would like to do the same (I doubt this is the nicest way to do so, but):

Edit /photoshare/templates/thumbnails/template.php

Search for:
$output->Text( $this->getThumbnailHTML($image['title'], $image['id'], $pos, $folderID, $templateHelper) );
Replace by:
$descimagen = addcslashes( pnVarPrepHTMLDisplay($image['description']), "\0..\37\"");
$output->Text( $this->getThumbnailHTML($image['title'], $image['id'], $pos, $folderID, $templateHelper, $descimagen) );

Search for:
function getThumbnailHTML($title, $id, $pos, $folderID, $templateHelper)
Replace by:
function getThumbnailHTML($title, $id, $pos, $folderID, $templateHelper, $descimagen)

Search for:
$html .= "";
Replace by:
$html .= "";

This way when browsing the images in thumbnail style, the comment on each image instead of being "click to enlarge" will be the image description. No clue on what might happen if you have 4 pages descriptions on an image, but I doubt noone does.

For your own sake - you should copy the whole template/thumbnails to templates/yourThumbnails - otherwise the next Photoshare installation will overwrite your changes!

Don't worry, I always upgrade with care.

I didn't quote it in there, but I always keep the old code commented out, and my own comments and even when I have changed something on a module, with a new version I always prefer to do a clean install, look for my comments on the old code and take then to the new code if they still apply, than not keep something I modified and risk losin new features or breaking anything up.

The only thing I have left now is do some more templates changes so when clicking on a thumb, instead of showing you the images with the slideshow templates it will pop it by itself on a new window.

Thanks for the advice! ;)

But if you make a copy then you can have *both* your own code *and* the old code in two different templates! And Photoshare installs will only overwrite the old - no need to be carefull when upgrading.

Anyway - your choice :-)